changes done with Prompt changing lab1#497
Open
deva9709 wants to merge 17 commits intoed-donner:mainfrom
Open
Conversation
Owner
|
This PR would change 15,000 lines of code across 37 files.... is that intentional?! |
Author
yeah, this has all the labs tested along with output. Thanks for reviewing. |
Owner
|
Hey - I'm super grateful that you're worked on this. It looks like this might not be ready to be merged - please can I ask you to review this: |
Author
|
Got you I’ll review. Thanks for suggestion.
…On Fri, 26 Dec 2025 at 5:00 PM, Ed Donner ***@***.***> wrote:
*ed-donner* left a comment (ed-donner/agents#497)
<#497 (comment)>
Hey - I'm super grateful that you're worked on this. It looks like this
might not be ready to be merged - please can I ask you to review this:
https://edwarddonner.com/pr
I very much look forward to merging when this is addressed. Thanks so much
Ed
—
Reply to this email directly, view it on GitHub
<#497 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADDCMDGCV7UQJRZVGD3FUVT4DUL4XAVCNFSM6AAAAACO4IQ4D6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMOJSG4ZTMOJYGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
need to add lab 1